Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ForceNew to ecs_service service_registries #17387

Merged
merged 5 commits into from
Mar 25, 2021
Merged

Add ForceNew to ecs_service service_registries #17387

merged 5 commits into from
Mar 25, 2021

Conversation

adam-tylr
Copy link
Contributor

@adam-tylr adam-tylr commented Feb 1, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17386

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEcsService_withServiceRegistriesChanges'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsService_withServiceRegistriesChanges -timeout 120m
=== RUN   TestAccAWSEcsService_withServiceRegistriesChanges
=== PAUSE TestAccAWSEcsService_withServiceRegistriesChanges
=== CONT  TestAccAWSEcsService_withServiceRegistriesChanges
--- PASS: TestAccAWSEcsService_withServiceRegistriesChanges (331.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	331.759s
...

@adam-tylr adam-tylr requested a review from a team as a code owner February 1, 2021 21:16
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 1, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 1, 2021
@adam-tylr adam-tylr mentioned this pull request Feb 12, 2021
Closed
@YakDriver YakDriver self-assigned this Mar 25, 2021
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 25, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Mar 25, 2021
@YakDriver YakDriver changed the base branch from master to main March 25, 2021 17:11
@YakDriver YakDriver closed this Mar 25, 2021
@YakDriver YakDriver reopened this Mar 25, 2021
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Mar 25, 2021
YakDriver
YakDriver approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Acceptance tests in commercial:

--- PASS: TestAccAWSEcsService_withServiceRegistriesChanges (352.06s)

GovCloud:

--- SKIP: TestAccAWSEcsService_withServiceRegistriesChanges (1.27s)

@YakDriver YakDriver added this to the v3.34.0 milestone Mar 25, 2021
@YakDriver YakDriver merged commit a01547a into hashicorp:main Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.34.0
Development

Successfully merging this pull request may close these issues.

ECS Service is not Re-created when Service Registries Changed
2 participants
@adam-tylr @YakDriver